Add const constructor to TextInputFormatter (#116654)

* Add const constructor to TextInputFormatter * Fix test * Add abstract * Add noSuchMethod Signed-off-by: Shogo Hida <[email protected]> * Add @OverRide and void Signed-off-by: Shogo Hida <[email protected]> * Fix text and position of test Signed-off-by: Shogo Hida <[email protected]> Signed-off-by: Shogo Hida <[email protected]>
Maatteogekko · Jan 18, 2023 · 780563c · 780563c
1 parent 0eaa83a
commit 780563c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/packages/flutter/lib/src/services/text_formatter.dart b/packages/flutter/lib/src/services/text_formatter.dart
@@ -88,6 +88,9 @@ enum MaxLengthEnforcement {
 ///  * [FilteringTextInputFormatter], a provided formatter for filtering
 ///    characters.
 abstract class TextInputFormatter {
+  /// This constructor enables subclasses to provide const constructors so that they can be used in const expressions.
+  const TextInputFormatter();
+
   /// Called when text is being typed or cut/copy/pasted in the [EditableText].
   ///
   /// You can override the resulting text based on the previous text value and

diff --git a/packages/flutter/test/services/text_formatter_test.dart b/packages/flutter/test/services/text_formatter_test.dart
@@ -6,10 +6,26 @@ import 'package:flutter/foundation.dart';
 import 'package:flutter/services.dart';
 import 'package:flutter_test/flutter_test.dart';
 
+class TestTextInputFormatter extends TextInputFormatter {
+  const TestTextInputFormatter();
+
+  @override
+  void noSuchMethod(Invocation invocation) {
+    super.noSuchMethod(invocation);
+  }
+}
+
 void main() {
   TextEditingValue testOldValue = TextEditingValue.empty;
   TextEditingValue testNewValue = TextEditingValue.empty;
 
+  test('test const constructor', () {
+    const TestTextInputFormatter testValue1 = TestTextInputFormatter();
+    const TestTextInputFormatter testValue2 = TestTextInputFormatter();
+
+    expect(testValue1, same(testValue2));
+  });
+
   test('withFunction wraps formatting function', () {
     testOldValue = TextEditingValue.empty;
     testNewValue = TextEditingValue.empty;