[Breaking change] Refactor the way we pass options to MadNLP #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
- Coverage 73.00% 72.96% -0.04%
==========================================
Files 38 38
Lines 3456 3459 +3
==========================================
+ Hits 2523 2524 +1
- Misses 933 935 +2
Continue to review full report at Codecov.
|
sshin23
approved these changes
Jul 8, 2022
src/IPM/IPM.jl
Outdated
|
|
||
| @assert is_supported(opt.linear_solver,T) | ||
|
|
||
| # Initiate linear-solver options |
There was a problem hiding this comment.
doing this here makes it much cleaner! Great idea
| setproperty!(opt,key,parse_option(T,val)) | ||
| pop!(option_dict,key) | ||
| function set_options!(opt::AbstractOptions, options) | ||
| other_options = Dict{Symbol, Any}() |
sshin23
reviewed
Jul 8, 2022
lib/MadNLPGPU/src/interface.jl
Outdated
| MadNLP.check_option_sanity(opt) | ||
|
|
||
| # Initiate linear-solver options |
There was a problem hiding this comment.
line 10-26 seems to be redundant to line 104-120 of IPM.jl. Can we create an internal function for setting options?
|
@sshin23 thanks for the review! I am all in to change the names of the functions in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the
option_dictandkwargsarguments, so now we pass all options askwargs...:No need to pass the options in a separate
Dictanymore.In addition, we add a new function
default_optionsto return the default options associated to a given linear solver.