-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LinearSolvers] Add support for LDL factorization in CHOLMOD #321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Have you observed any difference in performance?
I think that they they did a major upgrade of SuiteSparse between Julia 1.10 (SuiteSparse 7.0.4) and Julia 1.9 (SuiteSparse 5.1.0). |
Currently running the benchmark on OPF instances ! Cholmod-LDL was slower than LDLFactorizations in my previous tests, but I was not using the correct inertia in MadNLP.
Good point Alexis. I would suggest we support CHOLMOD-LDL only on Julia 1.10 then. What do you think would be best? |
Yes, I think that it's best to simply add a check for |
Agreed with @amontoison's suggestion |
cc @amontoison