Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOI] fix eval_constraint_jacobian_product #337

Merged
merged 1 commit into from
May 14, 2024
Merged

[MOI] fix eval_constraint_jacobian_product #337

merged 1 commit into from
May 14, 2024

Conversation

frapac
Copy link
Member

@frapac frapac commented May 13, 2024 •
edited
Loading

This PR fixes two issues that were not caught in the tests:

  • a variable was not defined in eval_constraint_jacobian_product
  • we should use the function eval_dense_gradient instead of eval_sparse_gradient as the vector Jtv is dense.

I think medium term, it would be nice to move the MOI utils functions directly inside MOI.

solve #336

@frapac frapac requested a review from sshin23 May 13, 2024 14:55
@frapac frapac mentioned this pull request May 13, 2024
Closed
@frapac frapac merged commit cdc1d0a into master May 14, 2024
7 checks passed
amontoison pushed a commit to amontoison/MadNLP.jl that referenced this pull request Jul 5, 2024
@frapac @amontoison
[MOI] fix eval_constraint_jacobian_product (MadNLP#337)
1c7c35b
@frapac frapac deleted the fp/fix_moi_lbfgs branch July 23, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshin23 sshin23 sshin23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frapac @sshin23