Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS class and Alert module #1353

Closed
Ybbet opened this issue Jul 10, 2018 · 2 comments
Closed

CSS class and Alert module #1353

Ybbet opened this issue Jul 10, 2018 · 2 comments

Comments

@Ybbet
Copy link
Contributor

Ybbet commented Jul 10, 2018

Please only submit reproducible issues.

If you're not sure if it's a real bug or if it's just you, please open a topic on the forum: https://forum.magicmirror.builders/category/15/bug-hunt
Problems installing or configuring your MagicMirror? Check out: https://forum.magicmirror.builders/category/10/troubleshooting

When submitting a new issue, please supply the following information:

Platform: Place your platform here... give us your web browser/Electron version and your hardware (Raspberry Pi 2/3, Windows, Mac, Linux, System V UNIX).

  • All

Node Version: Make sure it's version 0.12.13 or later.

v9.11.1

MagicMirror Version: Now that the versions have split, tell us if you are using the PHP version (v1) or the newer JavaScript version (v2).

v2 (2.5.0-dev)

Description: Provide a detailed description about the issue and include specific details to help us understand the problem. Adding screenshots will help describing the problem.

In the alert module, for messages, spans are used. The script adds inline styles instead of CSS classes.
Should not we evolve this part to replace these styles with the CSS class equivalent?
For titles, .light.dimmed.medium
And for messages: .thin.bright.small

Steps to Reproduce: List the step by step process to reproduce the issue.

Expected Results: Describe what you expected to see.

With those modifications, it will be easier to personnalize the alert with custom.css

@Ybbet Ybbet mentioned this issue Aug 1, 2018
MichMich added a commit that referenced this issue Aug 1, 2018
@MichMich
Copy link
Collaborator

MichMich commented Aug 1, 2018

Merged.

@MichMich MichMich closed this as completed Aug 1, 2018
@Ybbet
Copy link
Contributor Author

Ybbet commented Aug 1, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants