Calendar: Absolute dates do not show absolute even if getRelative and urgency are set to zero #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calendar module shows upcoming events with relative "today" and "tomorrow" even if the config defines all dates to be absolute - with the following configuration parameters:
getRelative: 0
timeFormat: "absolute"
urgency: 0
This patch adds an extra if to check whether timeFormat is absolute for events closer than 48 hours.
Further, it might make sense to refactor the whole time formatting function, as it has checks against both configurable and non-configurable values, and it uses different set of conditions for full day events and events with time frame.