Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc) showEnd config #1437

Merged
merged 4 commits into from
Oct 26, 2018
Merged

(doc) showEnd config #1437

merged 4 commits into from
Oct 26, 2018

Conversation

Duske
Copy link
Contributor

@Duske Duske commented Oct 8, 2018

Add documentation for showEnd configuration

Please send your pull requests the develop branch.
Don't forget to add the change to CHANGELOG.md.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.
Thanks!

  • Does the pull request solve a related issue?
  • If so, can you reference the issue?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.

MichMich and others added 2 commits October 1, 2018 08:16
Add documentation for showEnd configuration
@MagicMirrorBot
Copy link

Warnings
⚠️

Please include an updated CHANGELOG.md file.
This way we can keep track of all the contributions.

Generated by 🚫 dangerJS

@fewieden
Copy link
Contributor

fewieden commented Oct 8, 2018

@Duske pull requests should always go to develop not master, you can change that by editing the pull request on the top

@Duske Duske changed the base branch from master to develop October 9, 2018 08:48
@Duske
Copy link
Contributor Author

Duske commented Oct 9, 2018

@fewi I'm sorry, I adjusted the PR.

@Duske Duske mentioned this pull request Oct 20, 2018
@MichMich
Copy link
Collaborator

Thanks for your contribution! Sorry for the slow response. I've been on a holiday for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants