Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version spectron for 3.6.x #968

Merged

Conversation

roramirez
Copy link
Contributor

No description provided.

@roramirez
Copy link
Contributor Author

Hey @QNimbus

Sometimes vendors test still failing
https://travis-ci.org/MichMich/MagicMirror/jobs/258781699#L990

Some idea?

@QNimbus
Copy link
Contributor

QNimbus commented Jul 29, 2017

@roramirez I noticed this too; it seems random, and I haven't been able to pinpoint the problem yet. I will try to investigate as well, let me know if you come up with something!

@roramirez
Copy link
Contributor Author

Hey, I've thinking is not necessary for this test the use of beforeAll and afterAll.

What do you think? roramirez@9d7b048

@QNimbus
Copy link
Contributor

QNimbus commented Jul 31, 2017

Seems that this could work - can you try this fix and have it go through a Travis CI check?

@roramirez
Copy link
Contributor Author

its already in these builds
https://travis-ci.org/roramirez/MagicMirror/builds/259200820

I pushed the PR #977

@MichMich MichMich merged commit 66c9490 into MagicMirrorOrg:develop Aug 10, 2017
@roramirez roramirez deleted the set-version-test-dependencies branch August 11, 2017 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants