Fix this.file path #979
Merged
Fix this.file path #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichMich , seems to be a problem with the tests? What do I do now? |
|
Can you add an test into the testsuite to include this change? |
|
@CatoAntonsen You might want to close this pull request and re-open it. The test failure was not your fault; it was the vendor suite which was recently disabled by @roramirez. |
|
... Or merge your branch with |
This was referenced Jan 31, 2020
This was referenced Sep 27, 2021
This was referenced Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a small fix to make sure
this.file(filename)don't return double hash'es ( / ).An alternative solution would be to skip manually adding the hash, but I'm not 100% sure
this.data.pathallways ends with a hash.