Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SNR calculation for single BG frame files #116

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

jonschumacher
Copy link
Member

Files with only one BG frame result in SBG == meanBG which in turn results in noise == 0. This results in an SNR of Inf even though a correct SNR value could be calculated from the data. I fixed this and also added a fix for files which are not permuted to have the frame axis in the first dimension.

@jonschumacher jonschumacher requested a review from nHackel December 5, 2024 09:22
@jonschumacher jonschumacher self-assigned this Dec 5, 2024
@jonschumacher jonschumacher enabled auto-merge (squash) December 5, 2024 09:31
@jonschumacher jonschumacher merged commit 86ec896 into master Dec 5, 2024
8 checks passed
@jonschumacher jonschumacher deleted the JS/fix-snr-calculation branch December 5, 2024 09:36
nHackel referenced this pull request Jan 15, 2025
…Frames

Fix neglectBGFrames=false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants