-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to Maho's autoloaders #1
Conversation
I think we should remove support for "disabled local modules", it kinda doesn't even make sense anymore |
but otherwise we can merge as it is and tag a new release |
I'm not opposed to it since users can just use |
This reverts commit 9147b44.
no wait, for sure you can disable a single module in its app/etc/modules/xxxx.xml file, but I was referring to |
actually I think we were in agreement ahahhaha sorry :-D |
yup 👍. Removing support in PR #40 too. |
then I'll merge and tag this one! |
Sounds good! |
See MahoCommerce/maho#40 (comment)
We hook into the dump event and build PSR-0 prefixes, as well as classmaps for controllers which do not follow PSR-0 naming convention.
We also need to read local.xml to check if we have disabled local modules, as we must exclude those from our prefixes / classmaps. It would be too messy to try to do that at runtime.