chore: clean up unnecessary fields in core filters (#2455)

MaibornWolff · Jan 14, 2025 · eac344f · eac344f
1 parent 4555216
commit eac344f
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/backend/application/core/api/filters.py b/backend/application/core/api/filters.py
@@ -7,7 +7,6 @@
     ChoiceFilter,
     FilterSet,
     ModelChoiceFilter,
-    NumberFilter,
     OrderingFilter,
 )
 
@@ -73,7 +72,6 @@ class Meta:
 
 
 class ProductMemberFilter(FilterSet):
-    product = NumberFilter(field_name="product")
     is_product_group = BooleanFilter(field_name="product__is_product_group")
 
     ordering = OrderingFilter(
@@ -91,7 +89,6 @@ class Meta:
 
 
 class ProductAuthorizationGroupMemberFilter(FilterSet):
-    product = NumberFilter(field_name="product")
     is_product_group = BooleanFilter(field_name="product__is_product_group")
 
     ordering = OrderingFilter(
@@ -109,7 +106,6 @@ class Meta:
 
 
 class BranchFilter(FilterSet):
-    product = NumberFilter(field_name="product")
 
     ordering = OrderingFilter(
         # tuple-mapping retains order
@@ -169,21 +165,17 @@ class ObservationFilter(FilterSet):
         queryset=Product.objects.filter(is_product_group=True),
     )
 
-    has_pending_assessment = ChoiceFilter(
+    has_pending_assessment = BooleanFilter(
         field_name="has_pending_assessment",
         method="get_has_pending_assessment",
-        choices=[
-            ("true", "true"),
-            ("false", "false"),
-        ],
     )
 
     def get_has_pending_assessment(
         self, queryset, field_name, value
     ):  # pylint: disable=unused-argument
         # field_name is used as a positional argument
 
-        if value == "true":
+        if value:
             return queryset.filter(
                 id__in=Observation_Log.objects.filter(
                     assessment_status="Needs approval"