Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bulk reviews and separate reviews listing #2280

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

dervoeti
Copy link
Contributor

This is a change I have built a while ago and now found the time to actually clean it up and open a PR. It introduces the ability to do bulk approvals and also features a separate "Reviews" page.

Why I think this is helpful:

  • When someone does a huge bulk assessment, doing a bulk review of these assessments makes sense. There is usually no need to review all of these assessments one by one.
  • A separate "Reviews" page allows users to bulk approve assessments across products. At least at our company, it is a pretty common case that a vulnerability affects multiple products in the same way. Hence it's very helpful to be able to do a cross-product bulk assessment and approval. Also, it's a good place for people to discover assessments that need to be reviewed.

Further changes:

  • I added the possibility to filter assessments by component. We sometimes have the case that an assessment is basically the same across multiple products, but different for two components. For example, when two similar components that are both included in multiple products have observations for the same vulnerability, but only one of these components really contains the vulnerable code, while the other is a false positive. Then you want to create (and review) the assessment across all products, but separately per component.
  • I removed the "Assessment status" column in the review table because it seems like it would always display the same value.

This is not a really small change and it's been a while since I did it, it might needs some further adjustments, I just wanted to kick off the contribution process. I'll be offline for some days now but am happy to chat about this when I'm back (~9th of December). But feel absolutely free to change anything in this PR yourself and even merge it in the end if you like it.

@StefanFl
Copy link
Collaborator

StefanFl commented Dec 9, 2024

@dervoeti Please check my adjustments of your PR, before we merge it.

@StefanFl StefanFl merged commit 0d3e6dd into MaibornWolff:dev Dec 10, 2024
2 checks passed
StefanFl added a commit that referenced this pull request Dec 12, 2024
* fix: release to be sca scanned (#2286)

* chore(deps): update eslint monorepo to v9.16.0 (#2287)

* fix(deps): update dependency drf-spectacular to v0.28.0 (#2288)

* fix: prev/next button for license component show coming from overview list (#2289)

* feat: show observation on side of observation log (#2291)

* chore(deps): update dependency mkdocs-material to v9.5.47 (#2290)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency drf-spectacular-sidecar to v2024.12.1 (#2292)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency chart.js to v4.4.7 (#2293)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency pylint to v3.3.2 (#2294)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency globals to v15.13.0 (#2295)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update react-admin monorepo to v5.4.1 (#2297)

* chore(deps): update typescript-eslint monorepo to v8.17.0 (#2298)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update nginx:stable-alpine-slim docker digest to c13d84b (#2299)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update keycloak/keycloak docker tag to v26.0.7 (#2300)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update github/codeql-action action to v3.27.6 (#2301)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update node.js to v22.12.0 (#2303)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency prettier to v3.4.2 (#2304)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency axios to v1.7.9 (#2305)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency markdown-to-jsx to v7.7.1 (#2306)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update node.js to 96cc832 (#2308)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: do not change risk acceptance date inadvertently (#2302)

* fix: do not change risk acceptance date inadvertently

* chore: pylint

* feat: correct wrongly set dates

* chore: codereview

* chore: suppress false positive of Bandit (#2310)

* fix(deps): update dependency django to v5.1.4 (#2309)

* chore(deps): update dependency @types/react to v18.3.13 (#2311)

* feat: allow lists for CORS_ALLOWED_ORIGINS and ALLOWED_HOSTS (#2313)

* chore(deps): update dependency @eslint/compat to v1.2.4 (#2312)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/cache action to v4.2.0 (#2316)

* chore(deps): update dependency @types/prop-types to v15.7.14 (#2318)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update react monorepo (#2319)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency coverage to v7.6.9 (#2321)

* chore(deps): update dependency poetry to v1.8.5 (#2322)

* chore(deps): update dependency mkdocs-material to v9.5.48 (#2323)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency tss-react to v4.9.14 (#2324)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update emotion monorepo to v11.14.0 (#2325)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: bulk reviews and separate reviews listing (#2280)

* feat: bulk reviews and separate reviews listing

* fix: frontend lint fixes

* feat: UI improvements

* chore: finetuning

---------

Co-authored-by: Stefan Fleckenstein <[email protected]>

* chore(deps): update dependency @trivago/prettier-plugin-sort-imports to v5 (#2315)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update react-admin monorepo to v5.4.2 (#2326)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update typescript-eslint monorepo to v8.18.0 (#2327)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @types/react-dom to v18.3.3 (#2328)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @playwright/test to v1.49.1 (#2329)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update mcr.microsoft.com/playwright docker tag to v1.49.1 (#2330)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update github/codeql-action action to v3.27.7 (#2332)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update react monorepo (#2334)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update traefik docker tag to v3.2.2 (#2335)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @types/node to v22.10.2 (#2336)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: top level observation review list (#2337)

* chore: more authentication tests (#2338)

* chore: more authentication tests

* chore: black

* chore: two minor ui changes (#2339)

* chore(deps): lock file maintenance (#2296)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: prepare for release 1.23.0 (#2340)

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lukas Voetmand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants