Fix metric sum display #3534
Merged
Fix metric sum display #3534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't add tests for hiding metric values on hover because the nwsapi library used by JSDOM doesn't support testing CSS hover effects (testing-library/jest-dom#59). However imo the feature is minor enough, that covering this case with integration tests isn't needed. |
fritschldwg
force-pushed
the
fix/3532/metric-sum-display
branch
from
d260bb6 to
7e5cce0
Compare
|
PS: The changelog doesn't need to be updated since the original feature hasn't been released yet. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix metric sum display
Closes: #3532
Description
Descriptive pull request text, answering:
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled: