Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/3876/reset camera #3896

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Bug/3876/reset camera #3896

wants to merge 7 commits into from

Conversation

BenediktMehl
Copy link
Collaborator

@BenediktMehl BenediktMehl commented Jan 27, 2025

Fix auto fitting camera

Closes: #3876

Description

The camera should only be reseted (auto fitted) if there is a change to the area of the map (or the height scaling)

  • The list of selectors that trigger that reset needs to be completed.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

@BenediktMehl BenediktMehl force-pushed the bug/3876/reset-camera branch from 3d17347 to e2c768c Compare January 27, 2025 16:53
Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset Camera when changing map should not work on colors
1 participant