Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/3900/flipping delta maps #3903

Merged
merged 7 commits into from
Feb 3, 2025
Merged

Bug/3900/flipping delta maps #3903

merged 7 commits into from
Feb 3, 2025

Conversation

BenediktMehl
Copy link
Collaborator

@BenediktMehl BenediktMehl commented Jan 30, 2025 •
edited
Loading

Switching the two maps in delta mode doesn't change anything

Closes: #3900

Description

The "_onlyVisibleFilesMatterComparer" didn't notice the change if the two maps were flipped. I fixed that.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

@BenediktMehl BenediktMehl force-pushed the bug/3900/flipping-delta-maps branch from 4e9aa73 to a1991e3 Compare January 30, 2025 15:56
@BenediktMehl BenediktMehl force-pushed the bug/3900/flipping-delta-maps branch 2 times, most recently from 6570002 to 6971065 Compare January 31, 2025 14:17
@BenediktMehl BenediktMehl enabled auto-merge (rebase) January 31, 2025 14:26
auto-merge was automatically disabled February 2, 2025 12:27

Rebase failed

@BenediktMehl BenediktMehl force-pushed the bug/3900/flipping-delta-maps branch from cc779e2 to 0043002 Compare February 3, 2025 08:52
@BenediktMehl BenediktMehl force-pushed the bug/3900/flipping-delta-maps branch from 0043002 to 526d387 Compare February 3, 2025 08:54
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stephan-schneider-mw stephan-schneider-mw enabled auto-merge (rebase) February 3, 2025 09:05
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stephan-schneider-mw stephan-schneider-mw merged commit ca461bd into main Feb 3, 2025
8 checks passed
@stephan-schneider-mw stephan-schneider-mw deleted the bug/3900/flipping-delta-maps branch February 3, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IhsenBouallegue IhsenBouallegue IhsenBouallegue approved these changes

@stephan-schneider-mw stephan-schneider-mw stephan-schneider-mw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flipping maps in delta view does nothing
3 participants
@BenediktMehl @IhsenBouallegue @stephan-schneider-mw