Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database - general connection string support (feature request) #2533

Closed
ZsBT opened this issue Nov 14, 2022 · 1 comment · Fixed by #2534
Closed

database - general connection string support (feature request) #2533

ZsBT opened this issue Nov 14, 2022 · 1 comment · Fixed by #2534
Labels
type/feature Introduces a new feature

Comments

@ZsBT
Copy link

ZsBT commented Nov 14, 2022

Most languages support DB URL recently. Host, dbname, user, password do not cover the required connection parameters in all cases.
E.g., even psycopg2.connect can accept something like this:

postgresql://user:[email protected]:15757/roundcube?sslmode=verify-full&options=--cluster%3Ddeep-beast-666

We could give a new environment variable like this:

DB_CONNSTRING=postgresql://xyz...

@nextgens nextgens added the type/feature Introduces a new feature label Nov 15, 2022
@nextgens
Copy link
Contributor

I am fairly sure that if you get rid of DB_FLAVOR and set SQLALCHEMY_DATABASE_URI instead it will do the right thing. Granted this should be documented somewhere.

bors bot added a commit that referenced this issue Nov 15, 2022
2525: Switch to GrapheneOS's hardened_malloc r=mergify[bot] a=nextgens

## What type of PR?

Feature

## What does this PR do?

Switch to GrapheneOS's hardened_malloc

This was suggested during the dev meeting of the 18/09/22.

It may break things and it may make things unbearably slow... but it should also make the exploitation of memory corruption bugs a lot harder.

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


2534: Close #2533: document SQLALCHEMY_DATABASE_URI r=mergify[bot] a=nextgens

## What type of PR?

documentation

## What does this PR do?

document SQLALCHEMY_DATABASE_URI

### Related issue(s)
- closes #2533

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [x] In case of feature or enhancement: documentation updated accordingly
- [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: Florent Daigniere <[email protected]>
@bors bors bot closed this as completed in 6351360 Nov 15, 2022
nextgens added a commit to nextgens/Mailu that referenced this issue Nov 23, 2022
bors bot added a commit that referenced this issue Mar 26, 2023
2719: Introduce connection string (database url) for roundcube & simplify setup r=mergify[bot] a=Diman0

## What type of PR?

enhancement

## What does this PR do?
As discussed in earlier Mailu meetings (#1582), we want to simplify configuring Mailu and make it more user-friendly. Especially the last part is an important mission statement of the Mailu project. 

This PR will remove the choice of what DB to use from setup. New users are guided now to make the correct choice of using SQLite.

For simplifying the configuration, all the database environment variables have been removed and replaced with a single connection string environment variable. 

For backwards compatibility, the old *DB_* setting can still be used. This is to make sure that master does not immediately break for all users. After X months after the next Mailu release, we can remove the old settings from the software. This provides a transition period. 

### Related issue(s)
- #2533

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: Dimitri Huisman <[email protected]>
Co-authored-by: Florent Daigniere <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature Introduces a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants