Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PUBLIC_HOSTNAME/IP with real data in Received headers #1871

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

nextgens
Copy link
Contributor

What type of PR?

bug-fix

What does this PR do?

This will ensure that we don't get spam points for not respecting the RFC (gmail is notorious for not liking it)

Related issue(s)

Prerequistes

Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

  • In case of feature or enhancement: documentation updated accordingly
  • Unless it's docs or a minor change: add changelog entry file.

This will ensure that we don't get spam points for not respecting the
RFC
@nextgens nextgens added priority/p1 (Critical) bug with workaround / Should have type/backport Automatic backport this PR to the current stable release labels Jul 18, 2021
@nextgens nextgens added this to the 1.8 milestone Jul 18, 2021
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2021

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors bot added a commit that referenced this pull request Jul 18, 2021
@bors
Copy link
Contributor

bors bot commented Jul 18, 2021

try

Build succeeded:

@nextgens
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jul 19, 2021
@bors
Copy link
Contributor

bors bot commented Jul 19, 2021

try

Build succeeded:

Copy link
Member

@Diman0 Diman0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify
Copy link
Contributor

mergify bot commented Jul 20, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 20, 2021

Build succeeded:

@bors bors bot merged commit 0031f26 into Mailu:master Jul 20, 2021
bors bot added a commit that referenced this pull request Jul 20, 2021
1876: Replace PUBLIC_HOSTNAME/IP with real data in Received headers (backport #1871) r=mergify[bot] a=mergify[bot]

This is an automatic backport of pull request #1871 done by [Mergify](https://mergify.io).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.io/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.io/) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/
</details>


Co-authored-by: Florent Daigniere <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/p1 (Critical) bug with workaround / Should have type/backport Automatic backport this PR to the current stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants