Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GeoAxis size and protrusions #298

Merged
merged 10 commits into from
Dec 12, 2024
Merged

Fix GeoAxis size and protrusions #298

merged 10 commits into from
Dec 12, 2024

Conversation

asinghvi17
Copy link
Member

On master, even if you hide all decorations, the axis remains the same size - and looks pretty oversized.

This is for two reasons:

  • Protrusions were not zeroed out if the underlying plot was invisible
  • The axis was not "tight", i.e., finallimits had some added space because I hadn't enabled tightlimits for GeoAxis.

Both of these issues are fixed in this PR. It also introduces a per-axis-type needs_tight_limits overload, so that I can specify combinations of axes and plot types that need (or do not need) tight limits. Meshimage is also given tight limits by default now.

@asinghvi17 asinghvi17 merged commit c77dc2f into master Dec 12, 2024
1 of 2 checks passed
@asinghvi17 asinghvi17 deleted the as/oldprotrusions branch December 12, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant