-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tutorial on creating an inset plot #4697
Add a tutorial on creating an inset plot #4697
Conversation
@ffreyer @jkrumbiegel It would be great if someone can review this PR and provide feedback :) |
I think the part with the zoom lines would be better suited for the MakieExtras docs as it describes how to use its functions, and not how to do generic operations with Makies objects. I don't want to document other packages here if I don't have to as it increases the overall burden of keeping things up to date, plus, MakieExtras is specifically a package doing nonstandard things with some internals use etc. |
Do you suggest removing the MakieExtra package and zoom_lines function from the plot and keeping the rest? |
Yeah probably, it's already hard to keep the docs in sync with our own package, much less if we add others as well. I'd be open to showing how to do your own zoomlines, although it's maybe a little involved for a tutorial. On the other hand it would probably be good to showcase the |
I think we should either port zoomlines to Makie or document it in Makie Extras and link it in the docs. |
I do wonder if |
All public functionality in MakieExtra.jl is documented, including |
I think project is too much of a mess to advertise it.
|
Does it make sense to point to the zoomlines documentation within this tutorial or completely remove MakieExtra package and zoom_lines function from this tutorial? |
Awesome :) We could maybe still link the docs for zoom_lines? |
Added information about |
Is it possible to build the artifacts if there are no more changes to be done? |
Build was failing due to missing a CHANGELOG entry. Updated CHANGELOG.md file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to merge now. (Assuming the docs build doesn't fail)
Build was failing due to missing a CHANGELOG entry. Updated CHANGELOG.md file.
We usually don't add docs changes there but maybe it's good to have this one. May help make people aware of it.
Build has been successful and I hope this will be merged 🤞 |
Great work :) I've checked the uploaded artifact of the documentation and it seems to all work well! |
Latest CHANGELOG.md changes were conflicting with this branch so merged it. |
Description
Fixes #3292
This PR adds a tutorial on creating an inset plot. The related issue #3292 discusses 2 approaches to address this but I opted for the initial suggestion described in #3292 (comment).
The tutorial consists of 3 main parts.
Output image
Type of change
Delete options that do not apply:
Checklist