Curvilinear contourf
#4744
Open
Curvilinear contourf
#4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asinghvi17
commented
Jan 20, 2025
| return (polys, colors) | ||
| end | ||
|
|
||
| function Makie.plot!(c::Contourf{<:Union{<: Tuple{<:AbstractVector{<:Real}, <:AbstractVector{<:Real}, <:AbstractMatrix{<:Real}}, <: Tuple{<:AbstractMatrix{<:Real}, <:AbstractMatrix{<:Real}, <:AbstractMatrix{<:Real}}}}) |
There was a problem hiding this comment.
Does anyone have an idea of how to clean this up? One way would be to go through convert_arguments and just error there but it's harder to do that for conversion traits.
There was a problem hiding this comment.
Specifically I want to accept only (Vector, Vector, Matrix) or (Matrix, Matrix, Matrix) - at least for now
Benchmark ResultsSHA: 47f089c09a15121b09fb334d7a4722313dcd1dc2 Warning These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.
|
5 tasks
asinghvi17
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #796
This PR moves the contourf calculation outside the recipe so it can be dispatched on, and enables curvilinear
contourfby transforming the output from Isoband using bilinear interpolation on the (x, y) grid.@briochemc if you can make a PR against this branch that would be great!done!Type of change
Delete options that do not apply:
Checklist