Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TR Locales #262

Merged
merged 5 commits into from
Jul 28, 2024
Merged

Update TR Locales #262

merged 5 commits into from
Jul 28, 2024

Conversation

mikropsoft
Copy link

No description provided.

Copy link
Owner

@Malopieds Malopieds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some changes

app/src/main/res/values-tr/strings.xml Outdated Show resolved Hide resolved
@Malopieds
Copy link
Owner

Full stack trace:

`/home/runner/work/InnerTune/InnerTune/app/src/main/res/values-tr/strings.xml:12: Error: For locale "tr" (Turkish) the following quantity should also be defined: one (e.g. "Sepetinizde 1 X var. Bunu almak istiyor musunuz?") [MissingQuantity]

^

Explanation for issues of type "MissingQuantity":
Different languages have different rules for grammatical agreement with
quantity. In English, for example, the quantity 1 is a special case. We
write "1 book", but for any other quantity we'd write "n books". This
distinction between singular and plural is very common, but other languages
make finer distinctions.

This lint check looks at each translation of a and makes sure that
all the quantity strings considered by the given language are provided by
this translation.

For example, an English translation must provide a string for
quantity="one". Similarly, a Czech translation must provide a string for
quantity="few".

https://developer.android.com/guide/topics/resources/string-resource.html#Plurals`

I see you deleted also missingQuantities, if not important you can but here it's not compiling anymore so you should add it back, or fix the plurals.

@mikropsoft
Copy link
Author

Full stack trace:

`/home/runner/work/InnerTune/InnerTune/app/src/main/res/values-tr/strings.xml:12: Error: For locale "tr" (Turkish) the following quantity should also be defined: one (e.g. "Sepetinizde 1 X var. Bunu almak istiyor musunuz?") [MissingQuantity] ^

Explanation for issues of type "MissingQuantity": Different languages have different rules for grammatical agreement with quantity. In English, for example, the quantity 1 is a special case. We write "1 book", but for any other quantity we'd write "n books". This distinction between singular and plural is very common, but other languages make finer distinctions.

This lint check looks at each translation of a and makes sure that all the quantity strings considered by the given language are provided by this translation.

For example, an English translation must provide a string for quantity="one". Similarly, a Czech translation must provide a string for quantity="few".

https://developer.android.com/guide/topics/resources/string-resource.html#Plurals`

I see you deleted also missingQuantities, if not important you can but here it's not compiling anymore so you should add it back, or fix the plurals.

I didn't actually delete anything, and there's nothing missing. I synchronized everything with the English file, and even the number of lines is the same. Now, I'm reviewing it.

@mikropsoft mikropsoft requested a review from Malopieds July 28, 2024 10:57
app/src/main/res/values-tr/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-tr/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-tr/strings.xml Outdated Show resolved Hide resolved
@mikropsoft mikropsoft requested a review from Malopieds July 28, 2024 11:49
@Malopieds Malopieds merged commit d9b94b6 into Malopieds:dev Jul 28, 2024
1 check passed
@Malopieds
Copy link
Owner

Thank you for this PR and bearing with me !

Malopieds pushed a commit that referenced this pull request Aug 9, 2024
* Update TR Locales
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants