Skip to content

Commit

Permalink
readline does not work with ruby 3.3
Browse files Browse the repository at this point in the history
It's making the prompt disappear when enabled, disable for now until we can
get to highline 3.0+ where they switch to reline.
  • Loading branch information
bdunne committed Nov 26, 2024
1 parent a28622a commit 5d43286
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
8 changes: 2 additions & 6 deletions lib/manageiq/appliance_console/database_admin.rb
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,11 @@ def skip_file_location?(hostname)
end

def should_exclude_tables?
ask_yn?("Would you like to exclude tables in the dump") do |q|
q.readline = true
end
ask_yn?("Would you like to exclude tables in the dump")
end

def should_split_output?
ask_yn?("Would you like to split the #{action} output into multiple parts") do |q|
q.readline = true
end
ask_yn?("Would you like to split the #{action} output into multiple parts")
end

def filename_prompt_args
Expand Down
1 change: 0 additions & 1 deletion lib/manageiq/appliance_console/prompts.rb
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ def ask_with_menu(prompt, options, default = nil, clear_screen_after = true)

def just_ask(prompt, default = nil, validate = nil, error_text = nil, klass = nil)
ask("Enter the #{prompt}: ", klass) do |q|
q.readline = true
q.default = default.to_s if default
q.validate = validate if validate
q.responses[:not_valid] = error_text ? "Please provide #{error_text}" : "Please provide in the specified format"
Expand Down

0 comments on commit 5d43286

Please sign in to comment.