readline does not work with ruby 3.3 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's making the prompt disappear when enabled, disable for now until we can get to highline 3.0+ where they switch to reline.
jrafanie
reviewed
Nov 26, 2024
| @@ -212,7 +212,6 @@ def ask_with_menu(prompt, options, default = nil, clear_screen_after = true) | |||
|
|
|||
| def just_ask(prompt, default = nil, validate = nil, error_text = nil, klass = nil) | |||
| ask("Enter the #{prompt}: ", klass) do |q| | |||
| q.readline = true | |||
There was a problem hiding this comment.
Should we set it explicitly to false so we can easily update it "true" after we fix it / upgrade to newer highline
Fryguy
added a commit
that referenced
this pull request
Nov 27, 2024
Changed: Readline does not work with ruby 3.3 [#270]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readline is making the prompt disappear when enabled, disable for now until we can get to highline 3.0+ where they switch to reline.
Unfortunately this breaks the ability for users to use the arrow keys to fix typos in prompts, but it does make the prompts visible until we have the time to get to highline 3.0+.