Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2V] Remove PreMigration Ansible playbook #567

Merged
merged 2 commits into from
Aug 29, 2019
Merged

[V2V] Remove PreMigration Ansible playbook #567

merged 2 commits into from
Aug 29, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2019 •
edited by simaishi
Loading

The state machine is being ported to InfraConversionJob.
This PR is the counterpart of ManageIQ/manageiq#19200.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1745233
Depends on ManageIQ/manageiq#19200
Built on #566

@ghost
Copy link
Author

ghost commented Aug 26, 2019

@miq-bot add-label transformation, refactoring, ivanchuk/yes
@miq-bot add-reviewer @gmcculloug
@miq-bot add-reviewer @tinaafitz

@miq-bot
Copy link
Member

miq-bot commented Aug 26, 2019

Checked commits fabiendupont/manageiq-content@83796ef~...991de13 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@coveralls
Copy link

coveralls commented Aug 26, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 3499

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.9%
Totals Coverage Status
Change from base Build 3484: 0.0%
Covered Lines: 2970
Relevant Lines: 3065
💛 - Coveralls

@gmcculloug gmcculloug self-assigned this Aug 26, 2019
@gmcculloug gmcculloug requested a review from mkanoor August 26, 2019 21:03
@ghost ghost mentioned this pull request Aug 28, 2019
Merged
@gmcculloug gmcculloug merged commit 35fae0c into ManageIQ:master Aug 29, 2019
@gmcculloug gmcculloug added this to the Sprint 119 Ending Sep 2, 2019 milestone Aug 29, 2019
simaishi pushed a commit that referenced this pull request Oct 31, 2019
@gmcculloug @simaishi
Merge pull request #567 from fdupont-redhat/v2v_state_machine_remove_…
26def1d 
…pre_migration_ansible_playbook

[V2V] Remove PreMigration Ansible playbook

(cherry picked from commit 35fae0c)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767638
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 26def1da17f6609d95c10ee4a89bcf70b29c9c0e
Author: Greg McCullough <[email protected]>
Date:   Thu Aug 29 07:02:55 2019 -0400

    Merge pull request #567 from fdupont-redhat/v2v_state_machine_remove_pre_migration_ansible_playbook
    
    [V2V] Remove PreMigration Ansible playbook
    
    (cherry picked from commit 35fae0c6b5af0dafb9d2a0b1239e03c55b94a456)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767638

simaishi added a commit that referenced this pull request Dec 3, 2019
@simaishi
Revert "Merge pull request #567 from fdupont-redhat/v2v_state_machine…
bf4f2de 
…_remove_pre_migration_ansible_playbook"

This reverts commit 26def1d.

https://bugzilla.redhat.com/show_bug.cgi?id=1767638
@simaishi
Copy link
Contributor

simaishi commented Dec 3, 2019

The backport reverted

commit bf4f2de7863f51f896b2445cb5eba47c8649be43
Author: Satoe Imaishi <[email protected]>
Date:   Tue Dec 3 11:13:16 2019 -0500

    Revert "Merge pull request #567 from fdupont-redhat/v2v_state_machine_remove_pre_migration_ansible_playbook"

    This reverts commit 26def1da17f6609d95c10ee4a89bcf70b29c9c0e.

    https://bugzilla.redhat.com/show_bug.cgi?id=1767638

simaishi pushed a commit that referenced this pull request Feb 21, 2020
@gmcculloug @simaishi
Merge pull request #567 from fdupont-redhat/v2v_state_machine_remove_…
04de657 
…pre_migration_ansible_playbook

[V2V] Remove PreMigration Ansible playbook

(cherry picked from commit 35fae0c)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767638
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 04de657b29d0b5bbea2c108164a4e90a8990b157
Author: Greg McCullough <[email protected]>
Date:   Thu Aug 29 07:02:55 2019 -0400

    Merge pull request #567 from fdupont-redhat/v2v_state_machine_remove_pre_migration_ansible_playbook

    [V2V] Remove PreMigration Ansible playbook

    (cherry picked from commit 35fae0c6b5af0dafb9d2a0b1239e03c55b94a456)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcculloug gmcculloug Awaiting requested review from gmcculloug

@tinaafitz tinaafitz Awaiting requested review from tinaafitz

@mkanoor mkanoor Awaiting requested review from mkanoor

Assignees

@gmcculloug gmcculloug

Labels
changelog/yes ivanchuk/backported refactoring v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miq-bot @coveralls @simaishi @gmcculloug @fabiendupont