Favor Apache over Rails to display HTTP error documents #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
apache-error-document
branch
from
928a46f to
dd245da
Compare
|
This isn't really dynamic right? Would it be better to put this in one of the static files in the appliance repo (https://github.com/ManageIQ/manageiq-appliance/tree/master/COPY/etc/httpd/conf.d)? /cc @abellotti |
|
Sure thing, but I think we still need the |
|
static is fine, we needed to do this for external auth errors for Kerberos authentication (web SSO) https://github.com/ManageIQ/manageiq-appliance/blob/master/TEMPLATE/etc/httpd/conf.d/manageiq-external-auth.conf.erb |
|
We are no longer rendering these files from MiqApache at runtime. This change should be made in the manageiq-appliance repo here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bring us closer to unified error pages in both UIs ManageIQ/manageiq#14244