Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds spec for cloud network with availability zone #380

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Dec 20, 2017

This is a test for a bug fix where availability zone wasn't being updated after selection of cloud network.

expected failure is expected cause the code that makes this test pass is in linked pr

depends on

Test for ManageIQ/manageiq#16688

@d-m-u
Copy link
Contributor Author

d-m-u commented Dec 20, 2017

@syncrou will you look at this please for me thanks

@d-m-u d-m-u force-pushed the adding_specs_for_cloud_networks_with_zones branch from 50932df to 318b65c Compare December 20, 2017 17:22
@d-m-u d-m-u force-pushed the adding_specs_for_cloud_networks_with_zones branch from 318b65c to 421eaf0 Compare December 20, 2017 19:17
@bronaghs
Copy link

LGTM once ManageIQ/manageiq#16688 is merged.

@bronaghs bronaghs added the wip label Dec 20, 2017
@bronaghs bronaghs changed the title Adds spec for cloud network with availability zone [WIP] Adds spec for cloud network with availability zone Dec 20, 2017
@d-m-u d-m-u closed this Jan 2, 2018
@d-m-u
Copy link
Contributor Author

d-m-u commented Jan 2, 2018

These specs are being moved to ManageIQ/manageiq#16707 per request of the Powers That Be.

@miq-bot
Copy link
Member

miq-bot commented Jan 11, 2018

Checked commit d-m-u@421eaf0 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@bronaghs
Copy link

@d-m-u Should this PR be closed if these specs are moving to the manageiq repo as indicated above?

@d-m-u d-m-u closed this Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants