Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in missing user creation audit event. #479

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Add in missing user creation audit event. #479

merged 1 commit into from
Aug 27, 2018

Conversation

juliancheal
Copy link
Member

Recieved from this PR ManageIQ/manageiq#17852

@agrare agrare self-assigned this Aug 27, 2018
@juliancheal
Copy link
Member Author

@agrare tests are passing locally, but I'm not sure where userNameType in the message

message => "User creation successful for User: userNameType with ID: #{username}"

is coming from :(

@miq-bot
Copy link
Member

miq-bot commented Aug 27, 2018

Checked commit https://github.com/juliancheal/manageiq-providers-amazon/commit/c5ce0babb75b6fa338dd21bc62793ae692e7a464 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@agrare
Copy link
Member

agrare commented Aug 27, 2018

@juliancheal looks like it is coming from here

   83:     def update_user_attributes(user, username, amazon_user)
=> 84:       user.userid = username
   85:       user.name   = amazon_user.name
   86:     end
   87: 
   88:     private
(byebug) amazon_user
#<Aws::IAM::User name="userNameType">

@agrare
Copy link
Member

agrare commented Aug 27, 2018

I think we can improve the stubbed user to give it a better username, merging this for now to get the repo back to green.

@agrare agrare merged commit c5ce0ba into ManageIQ:master Aug 27, 2018
agrare added a commit that referenced this pull request Aug 27, 2018
Add in missing user creation audit event.
@agrare agrare added this to the Sprint 93 Ending Aug 27, 2018 milestone Aug 27, 2018
@juliancheal
Copy link
Member Author

@agrare ah are we getting that from the user stubbing? I see, that explains why I hadn't seen it I was testing the original PR with actual amazon log in.

@bronaghs bronaghs added the test label Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants