Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping azure classic and rackspace credential types #58

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Dropping azure classic and rackspace credential types #58

merged 1 commit into from
Feb 6, 2018

Conversation

jameswnl
Copy link
Contributor

@jameswnl jameswnl commented Feb 2, 2018 •
edited by blomquisg
Loading

@jameswnl
Copy link
Contributor Author

jameswnl commented Feb 2, 2018

We may consider to port this to Gaprindashvili

@jameswnl jameswnl mentioned this pull request Feb 2, 2018
Closed
21 tasks
@gmcculloug gmcculloug added the wip label Feb 2, 2018
@gmcculloug gmcculloug changed the title Dropping azure classic credential [WIP] Dropping azure classic credential Feb 2, 2018
@jameswnl jameswnl mentioned this pull request Feb 5, 2018
Merged
@jameswnl jameswnl changed the title [WIP] Dropping azure classic credential Dropping azure classic and rackspace credential types Feb 5, 2018
@jameswnl
Copy link
Contributor Author

jameswnl commented Feb 5, 2018

@miq-bot add_label gaprindashvili/yes
@miq-bot remove_label wip

@miq-bot
Copy link
Member

miq-bot commented Feb 5, 2018

Checked commit https://github.com/jameswnl/manageiq-providers-ansible_tower/commit/5ac4dcd0278d06b34cea9c0bedd976a2a866bf89 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 👍

@blomquisg blomquisg added the bug label Feb 6, 2018
@blomquisg blomquisg merged commit 7ebd8ef into ManageIQ:master Feb 6, 2018
@gmcculloug gmcculloug added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 6, 2018
@jameswnl jameswnl deleted the v2cred branch February 6, 2018 18:28
@jameswnl
Copy link
Contributor Author

jameswnl commented Feb 6, 2018

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Feb 6, 2018
simaishi pushed a commit that referenced this pull request Feb 6, 2018
@blomquisg @simaishi
Merge pull request #58 from jameswnl/v2cred
18c6f1c 
Dropping azure classic and rackspace credential types
(cherry picked from commit 7ebd8ef)

https://bugzilla.redhat.com/show_bug.cgi?id=1542738
@simaishi
Copy link
Contributor

simaishi commented Feb 6, 2018

Gaprindashvili backport details:

$ git log -1
commit 18c6f1cdc3c9c1f58bf74f1df19a9d4a2715c567
Author: Greg Blomquist <[email protected]>
Date:   Tue Feb 6 11:32:16 2018 -0500

    Merge pull request #58 from jameswnl/v2cred
    
    Dropping azure classic and rackspace credential types
    (cherry picked from commit 7ebd8ef6960c92c5dac67a86cac4d78ba519696d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1542738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@blomquisg blomquisg

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jameswnl @miq-bot @simaishi @blomquisg @gmcculloug @mimodian