Persister: InventoryCollection building through add_collection() #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2018
slemrmartin
changed the title
slemrmartin
changed the title
|
Core PR merged kicking tests |
|
I just updated the VCR cassettes, not sure if that's got you messed up or not, but thought I would mention it. |
|
I didn't add parents back from core yet. That's why it is WIP now, i'm going to finish it next week, @djberg96 thx for info. |
Persister's add_collection() interface
Methods with class names unified across providers
Due to not adding automatic adding to core. Also renamed IC def folder
slemrmartin
force-pushed
the
inventory-collection-builder
branch
from
7e9be14 to
5175094
Compare
|
Checked commits slemrmartin/manageiq-providers-azure@712627e~...5175094 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
slemrmartin
changed the title
|
@miq-bot add_label refactoring |
agrare
added a commit
that referenced
this pull request
Jun 12, 2018
Persister: InventoryCollection building through add_collection()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: ManageIQ/manageiq#17396
New Interface for definition/creating InventoryCollection from persister.
Using add_collection() instead of add_inventory_collection() to build collections.
Builder classes are defined on core project, provider specific InventoryCollections specified in concerns