Adjusted DDF schema and validation #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
ddf-create-edit
branch
from
c7bcb53 to
cb82165
Compare
Merged
9 tasks
skateman
force-pushed
the
ddf-create-edit
branch
from
cb82165 to
aaa4a5c
Compare
skateman
changed the title
|
Checked commit skateman@0c92774 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
agrare
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DDF schema had to be adjusted to the DB schema field names, then the validation has been adjusted to pass again. On top of this I implemented the create and edit methods that can consume the data format produced by the forms.
@agrare I tested this blindly by forcing the validation to return true, but we might want to ask our xlab friends to try this out for real.
Old:
New:
Parent issue: ManageIQ/manageiq#18818