Extend allowed_cloud_network for providers that don't support allowed_ci #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @gmcculloug |
d-m-u
changed the title
|
@miq-bot add_label bug |
d-m-u
changed the title
|
@miq-bot add_label gaprindashvili/yes |
syncrou
suggested changes
Jan 16, 2018
| def allowed_cloud_networks(_options = {}) | ||
| return {} unless (src_obj = provider_or_tenant_object) | ||
|
|
||
| src_obj.all_cloud_networks.each_with_object({}) do |cn, hash| |
d-m-u
force-pushed
the
fixing_allowed_cloud_networks
branch
from
cd4a662 to
6e810a5
Compare
syncrou
reviewed
Jan 16, 2018
| let(:template) { FactoryGirl.create(:template_google, :name => "template", :ext_management_system => ems) } | ||
| let(:workflow) do | ||
| stub_dialog | ||
| allow_any_instance_of(User).to receive(:get_timezone).and_return(Time.zone) |
There was a problem hiding this comment.
@d-m-u - You should be able to swap out line 9 with allow(User).to receive_messages(:server_timezone => "UTC") to get rid of one of the Rubocop warnings about allow_any_instance_of
d-m-u
force-pushed
the
fixing_allowed_cloud_networks
branch
3 times, most recently
from
488fedd to
1d8775b
Compare
d-m-u
force-pushed
the
fixing_allowed_cloud_networks
branch
from
1d8775b to
e284168
Compare
|
Checked commit d-m-u@e284168 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR ManageIQ/manageiq#16811 adds RBAC filtering to allowed_cloud_network base class but two of the providers don't support the allowed_ci method so for them we need to overwrite the allowed_cloud_networks, to just return allowed_cloud_networks. Which this does! (Per ManageIQ/manageiq#16824 (comment))
Fixes issue caused by fix of https://bugzilla.redhat.com/show_bug.cgi?id=1533277
(Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1535189)
Related to:
ManageIQ/manageiq-providers-openstack#197