Test availability_zone_to_cn overriding in google prov #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bronaghs
reviewed
Feb 26, 2018
| stub_dialog | ||
| allow(User).to receive_messages(:server_timezone => "UTC") | ||
| wf = described_class.new({:src_vm_id => template.id}, admin.userid) | ||
| wf |
There was a problem hiding this comment.
@d-m-u - can this just read? :
described_class.new({:src_vm_id => template.id}, admin.userid)
gmcculloug
reviewed
Feb 26, 2018
| stub_dialog | ||
| allow(User).to receive_messages(:server_timezone => "UTC") | ||
| wf = described_class.new({:src_vm_id => template.id}, admin.userid) | ||
| wf |
There was a problem hiding this comment.
No need to set the wf variable only to return it on the next line. Just return the result from described_class.new.
d-m-u
force-pushed
the
add_cloud_network_test
branch
from
b222fbe to
09758aa
Compare
|
Checked commit d-m-u@09758aa with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@d-m-u - both comments ( #44 (comment) and #44 (review)) are making the same point, FYI. |
gmcculloug
approved these changes
Mar 5, 2018
simaishi
pushed a commit
that referenced
this pull request
Mar 22, 2018
Test availability_zone_to_cn overriding in google prov (cherry picked from commit 7e547f5)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR ManageIQ/manageiq#16811 adds RBAC filtering to allowed_cloud_network base class and google needed specs around the fact that the cloud network list is NOT dependent on availability zone choice unlike azure and amazon. (Per ManageIQ/manageiq#16824 (comment))
Related bz links:
https://bugzilla.redhat.com/show_bug.cgi?id=1533277
https://bugzilla.redhat.com/show_bug.cgi?id=1535189