Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: remove google-containers images listing #63

Closed

Conversation

tumido
Copy link
Member

@tumido tumido commented Jun 15, 2018

Google recently removed google-containers from the Public images list.

Before fog/fog-google#356 makes it to the gem we need a quick workaround.

We may also need to regenerate VCR for refresh.

Fixes bug: https://bugzilla.redhat.com/show_bug.cgi?id=1591272
Upstream fix: fog/fog-google#356

@miq-bot add_label blocker, bug, gaprindashvili/yes, inventory

@tumido tumido force-pushed the remove_google_containers_image_listing branch from acc5be1 to 0a0fa47 Compare June 15, 2018 12:12
@tumido
Copy link
Member Author

tumido commented Jun 15, 2018

I've manually updated the VCR cassette and stripped the call for google-containers images. If we need that any time again we can just revert this change to the VCR.

@miq-bot
Copy link
Member

miq-bot commented Jun 15, 2018

Checked commits tumido/manageiq-providers-google@0a0fa47~...267e4b8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@tumido
Copy link
Member Author

tumido commented Jun 15, 2018

@miq-bot remove_label blocker

@miq-bot miq-bot removed the blocker label Jun 15, 2018
@tumido
Copy link
Member Author

tumido commented Jun 16, 2018

Upstream PR has been merged and fog-google 1.5.0 has been released. I'll prepare a PR bumping fog to 1.5.0 shortly. Once that is done, this fix won't be necessary and we might not need to merge this PR. @bronaghs, what do you think? The changes between 1.3.3 and 1.5.0 should involve bugfixes only, so it may only remove couple of workarounds we have and otherwise it should work fine.

@tumido
Copy link
Member Author

tumido commented Jun 18, 2018

@miq-bot add_label technical debt

@tumido
Copy link
Member Author

tumido commented Jun 18, 2018

Closing in favor of #64

@tumido tumido closed this Jun 18, 2018
@tumido tumido deleted the remove_google_containers_image_listing branch June 18, 2018 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants