Persister: InventoryCollection building through add_collection() #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Persister's add_collection() interface
This was referenced Jun 25, 2018
|
Checked commit slemrmartin@9fcac27 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@slemrmartin Please make sure that the specs are passing. |
|
@pkliczewski it should be ok when core PR will be merged, I'll restart tests after it. |
|
@pkliczewski can you merge this? It is holding up cleanup on master |
|
@agrare I am sorry for not handling this in timely manner. I was on PTO. |
|
@pkliczewski I guess I'll let it slide this time 🤣 hope you had a good time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: ManageIQ/manageiq#17396
New Interface for definition/creating InventoryCollection from persister.
Using add_collection() instead of add_inventory_collection() to build collections.
Builder classes are defined on core project, provider specific InventoryCollections specified in concerns