Graph refresh specs #238
Graph refresh specs #238
Conversation
|
Cc @Ladas @agrare @douglasgabriel |
slemrmartin
force-pushed
the
graph-refresh-spec
branch
from
0353a45 to
13ee954
Compare
|
integrated #232 to graph refresh |
slemrmartin
force-pushed
the
graph-refresh-spec
branch
from
13ee954 to
534d45d
Compare
|
#233 integrated |
slemrmartin
force-pushed
the
graph-refresh-spec
branch
from
534d45d to
dde6a84
Compare
|
@slemrmartin can you rebase? |
slemrmartin
force-pushed
the
graph-refresh-spec
branch
from
dde6a84 to
2010802
Compare
|
@douglasgabriel Are you from Lenovo? Please notice that Refresh spec is now using graph refresh code instead old code. Based on flag https://github.com/ManageIQ/manageiq-providers-lenovo/pull/238/files#diff-ff337ad5f24e45e4fbe0d6a7a21eed09R39 and https://github.com/ManageIQ/manageiq-providers-lenovo/pull/236/files#diff-646ad6b10917e4385cbcc8c8524e24a2R373 (which will switch using graph refresh in production too) |
|
@EsdrasVP pls notice ^^^ |
| @@ -17,6 +32,19 @@ | |||
| end | |||
| end | |||
|
|
|||
| before(:each) do | |||
| stub_settings_merge( | |||
There was a problem hiding this comment.
we should be testing the old refresh too, if we are keeping it around
also e.g. on Azure we test that old refresh and new refresh result in the same DB records.
There was a problem hiding this comment.
it's tested, I'll add it
| expect(ComputerSystem.count).to eq(10) | ||
| expect(Hardware.count).to eq(11) | ||
| expect(GuestDevice.count).to eq(14) | ||
| # expect(Firmware.count).to eq(20) |
There was a problem hiding this comment.
@douglasgabriel This line is not true for first round of old refresh. It's equal only in 2nd round and both rounds of graph refresh
There was a problem hiding this comment.
| # expect(Firmware.count).to eq(20) | |
| expect(Firmware.count).to eq(20) |
Please rebase this PR and remove the #
There was a problem hiding this comment.
@CharlleDaniel done
@slemrmartin thanks for you report, I found a little problem in the firmware parse of |
slemrmartin
force-pushed
the
graph-refresh-spec
branch
from
569f6f9 to
73041cf
Compare
|
@Ladas please merge |
|
This pull request is not mergeable. Please rebase and repush. |
slemrmartin
force-pushed
the
graph-refresh-spec
branch
from
73041cf to
8747076
Compare
|
merged #235 |
slemrmartin
force-pushed
the
graph-refresh-spec
branch
2 times, most recently
from
ed4d38b to
f98b576
Compare
integration of old refresh change, PR ManageIQ#232
Integration of PR ManageIQ#233 to graph refresh
slemrmartin
force-pushed
the
graph-refresh-spec
branch
from
f98b576 to
efc104f
Compare
slemrmartin
force-pushed
the
graph-refresh-spec
branch
from
efc104f to
2596c62
Compare
|
Checked commits slemrmartin/manageiq-providers-lenovo@f02cb5f~...2596c62 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/models/manageiq/providers/lenovo/physical_infra_manager/refresher_spec.rb
|
Specs are created against old refresh, then values were checked against graph refresh
depends on: #236