Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle deleted entities #116

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Sep 18, 2018

Process delete notices

Depends on: ManageIQ/manageiq-providers-kubernetes#291

@agrare agrare force-pushed the handle_deleted_entities branch 3 times, most recently from a24bc43 to eb3fac6 Compare September 19, 2018 13:34
@agrare agrare closed this Sep 19, 2018
@agrare agrare reopened this Sep 19, 2018
@agrare agrare force-pushed the handle_deleted_entities branch 2 times, most recently from 44ee98b to 3bf3da1 Compare September 19, 2018 15:49
@agrare agrare force-pushed the handle_deleted_entities branch from 3bf3da1 to bf2cff3 Compare September 19, 2018 16:08
@miq-bot
Copy link
Member

miq-bot commented Sep 19, 2018

Some comments on commit agrare@bf2cff3

spec/models/manageiq/providers/openshift/container_manager/refresher_inventory_object_spec.rb

  • 💣 💥 🔥 🚒 - 96 - Detected cloudforms

@miq-bot
Copy link
Member

miq-bot commented Sep 19, 2018

Checked commit agrare@bf2cff3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ladas Ladas merged commit 3e47d80 into ManageIQ:master Sep 20, 2018
@Ladas Ladas added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 20, 2018
@agrare agrare deleted the handle_deleted_entities branch September 20, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants