Use the kubernetes options for Openshift #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enoodle
changed the title
enoodle
changed the title
moolitayer
approved these changes
Aug 3, 2017
enoodle
force-pushed
the
use_new_options_for_provider_settings
branch
from
d49cbc2 to
322478a
Compare
|
This pull request is not mergeable. Please rebase and repush. |
enoodle
force-pushed
the
use_new_options_for_provider_settings
branch
from
322478a to
8c222a6
Compare
enoodle
force-pushed
the
use_new_options_for_provider_settings
branch
from
8c222a6 to
cd40ce9
Compare
|
ping @moolitayer |
|
Checked commit enoodle@cd40ce9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@enoodle we have a minimal two reviewer per PR policy. Please get another review. |
cben
approved these changes
Aug 13, 2017
| @@ -0,0 +1,4 @@ | |||
| module ManageIQ::Providers::Openshift::ContainerManager::Options | |||
| extend ActiveSupport::Concern | |||
There was a problem hiding this comment.
👍 without this, the ClassMethods would be available as class methods on this module, but not on Openshift::ContainerManager that includes it. 😭 😆 oh well ruby is weird sometimes...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ManageIQ/manageiq-providers-kubernetes#45 for Openshift provider options.
This is required for using the options field with the Openshift provider as it adds the static description of the options (That is then being served through the API to the UI to present to the user when editing the options)