Move code from manageiq-gems-pending

[jhernand]

Now that the oVirt provider has been extracted to a separate repository,
it makes sense to move all the oVirt specific code from
'manageiq-gems-pending' to this repository.

This patch moves the 'ovirt_event_monitor.rb' and 'ovirt_inventory.rb'
files. These files implement event monitoring and inventory collection,
using version 3 of the oVirt API and the 'ovirt' gem. As there is an
ongoing effort to use version 4 of the oVirt API, and the oVirt SDK,
these files have been added to a new 'ManageIQ::Providers::Ovirt::Legacy'
module, to make it explicit that this code will eventually be removed.

#8

[jhernand]

Note that this should be merged before ManageIQ/manageiq-gems-pending#118.

[miq-bot]

Checked commit https://github.com/jhernand/manageiq-providers-ovirt/commit/d0dd9819500bf08d7fce4bfa8c9586a93775b624 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 9 offenses detected

lib/manageiq/providers/ovirt/legacy/inventory.rb

• ⚠️ - Line 168, Col 53 - Lint/UnusedBlockArgument - Unused block argument - key. If it's necessary, use _ or _key as an argument name to indicate that it won't be used.
• ❗ - Line 123, Col 27 - Style/MutableConstant - Freeze mutable objects assigned to constants.
• ❗ - Line 135, Col 29 - Style/MutableConstant - Freeze mutable objects assigned to constants.
• ❗ - Line 170, Col 43 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 170, Col 82 - Style/EmptyLiteral - Use array literal [] instead of Array.new.
• ❗ - Line 175, Col 17 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 175, Col 59 - Style/EmptyLiteral - Use array literal [] instead of Array.new.
• ❗ - Line 188, Col 15 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 86, Col 23 - Style/RescueModifier - Avoid using rescue in its modifier form.

[durandom]

Any reason you chose to move them to lib/?
I think this all could easily go to app/models/manageiq/providers/redhat

[jhernand]

The only reason is that these classes are used by those test scripts that I don't know where to place. Those are in the manageiq-gems-pending repo. Not sure if they can be used from that repo if they aren't in the lib directory of this gem. Once we decide what we do with those test scripts, an once I know how to test them, I can move the files to app/models no objection to that.

[bdunne]

👍 LGTM. Thanks @jhernand