-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check EmsEvents when disconnecting storage #336
Check EmsEvents when disconnecting storage #336
Conversation
Instead of the EventHandler calling disconnect_storage when DestroyVM_Task_Complete is processed check the ems_events for UnregisterVM_Complete. https://bugzilla.redhat.com/show_bug.cgi?id=1644770
Checked commit agrare@772e1d3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks like it could work
:event_type has an index, so it shouldn't affect performance much
@agrare anything else needed prior to merge. |
@JPrause ManageIQ/manageiq#18200 needs to be merged |
…n_disconnecting_vms Check EmsEvents when disconnecting storage (cherry picked from commit f73e67f) https://bugzilla.redhat.com/show_bug.cgi?id=1654436
Gaprindashvili backport details:
|
…n_disconnecting_vms Check EmsEvents when disconnecting storage (cherry picked from commit f73e67f) https://bugzilla.redhat.com/show_bug.cgi?id=1644770
Hammer backport details:
|
Restore VM power state upon transformation
Instead of the EventHandler calling disconnect_storage when
DestroyVM_Task_Complete is processed check the ems_events for
UnregisterVM_Complete.
Depends: ManageIQ/manageiq#18200
https://bugzilla.redhat.com/show_bug.cgi?id=1644770