Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check EmsEvents when disconnecting storage #336

Conversation

agrare
Copy link
Member

@agrare agrare commented Nov 14, 2018

Instead of the EventHandler calling disconnect_storage when
DestroyVM_Task_Complete is processed check the ems_events for
UnregisterVM_Complete.

Depends: ManageIQ/manageiq#18200

https://bugzilla.redhat.com/show_bug.cgi?id=1644770

Instead of the EventHandler calling disconnect_storage when
DestroyVM_Task_Complete is processed check the ems_events for
UnregisterVM_Complete.

https://bugzilla.redhat.com/show_bug.cgi?id=1644770
@miq-bot
Copy link
Member

miq-bot commented Nov 14, 2018

Checked commit agrare@772e1d3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@agrare agrare changed the title Check EmsEvents when disconnecting storage [WIP] Check EmsEvents when disconnecting storage Nov 14, 2018
@miq-bot miq-bot added the wip label Nov 14, 2018
@agrare agrare changed the title [WIP] Check EmsEvents when disconnecting storage Check EmsEvents when disconnecting storage Nov 15, 2018
@agrare agrare removed the wip label Nov 15, 2018
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks like it could work

:event_type has an index, so it shouldn't affect performance much

@JPrause
Copy link
Member

JPrause commented Nov 26, 2018

@agrare anything else needed prior to merge.

@agrare
Copy link
Member Author

agrare commented Nov 26, 2018

@JPrause ManageIQ/manageiq#18200 needs to be merged

@Fryguy Fryguy merged commit f73e67f into ManageIQ:master Nov 28, 2018
@Fryguy Fryguy added this to the Sprint 100 Ending Dec 3, 2018 milestone Nov 28, 2018
@agrare agrare deleted the bz_1644770_disconnect_storage_when_disconnecting_vms branch November 28, 2018 15:48
simaishi pushed a commit that referenced this pull request Nov 28, 2018
…n_disconnecting_vms

Check EmsEvents when disconnecting storage

(cherry picked from commit f73e67f)

https://bugzilla.redhat.com/show_bug.cgi?id=1654436
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit bd97d36dd291a7decd01e0a3c762f8080fdf43e2
Author: Jason Frey <[email protected]>
Date:   Wed Nov 28 10:32:26 2018 -0500

    Merge pull request #336 from agrare/bz_1644770_disconnect_storage_when_disconnecting_vms
    
    Check EmsEvents when disconnecting storage
    
    (cherry picked from commit f73e67f64056d8a56ac78597824203ac58671319)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1654436

simaishi pushed a commit that referenced this pull request Dec 3, 2018
…n_disconnecting_vms

Check EmsEvents when disconnecting storage

(cherry picked from commit f73e67f)

https://bugzilla.redhat.com/show_bug.cgi?id=1644770
@simaishi
Copy link
Contributor

simaishi commented Dec 3, 2018

Hammer backport details:

$ git log -1
commit 3b5065cf14adeb3c733734ca47ebc7a2b584cf83
Author: Jason Frey <[email protected]>
Date:   Wed Nov 28 10:32:26 2018 -0500

    Merge pull request #336 from agrare/bz_1644770_disconnect_storage_when_disconnecting_vms
    
    Check EmsEvents when disconnecting storage
    
    (cherry picked from commit f73e67f64056d8a56ac78597824203ac58671319)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1644770

agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
Restore VM power state upon transformation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants