Merge pull request #2757 from lgalis/fix_vm_transform_from_infra_prov…

…ider

VM Transform not working from a provider page

app/controllers/application_controller/ci_processing.rb

@@ -15,6 +15,7 @@ module ApplicationController::CiProcessing
     include Mixins::Actions::VmActions::Reconfigure
     helper_method :supports_reconfigure_disks?
     include Mixins::Actions::VmActions::PolicySimulation
+    include Mixins::Actions::VmActions::Transform
 
     include Mixins::Actions::HostActions::Discover
     include Mixins::Actions::HostActions::Power
@@ -1063,6 +1064,7 @@ def process_vm_buttons(pfx)
     when "#{pfx}_terminate"                 then terminatevms
     when "instance_add_security_group"      then add_security_group_vms
     when "instance_remove_security_group"   then remove_security_group_vms
+    when "vm_transform"                     then vm_transform
     end
   end
 

app/controllers/mixins/actions/vm_actions/transform.rb

@@ -0,0 +1,27 @@
+module Mixins
+  module Actions
+    module VmActions
+      module Transform
+        def vm_transform
+          dialog = Dialog.find_by(:label => 'Transform VM')
+          if params.key?(:id)
+            vm = Vm.find_by(:id => params[:id].to_i)
+            @right_cell_text = _("Transform VM %{name} to RHV") % {:name => vm.name}
+            dialog_initialize(
+              dialog.resource_actions.first,
+              :header     => @right_cell_text,
+              :target_id  => vm.id,
+              :target_kls => Vm.name
+            )
+          else
+            @right_cell_text = _("Transform VMs to RHV")
+            simple_dialog_initialize(
+              dialog.resource_actions.first,
+              :header => @right_cell_text
+            )
+          end
+        end
+      end
+    end
+  end
+end

app/controllers/vm_infra_controller.rb

@@ -96,24 +96,4 @@ def simple_dialog_initialize(ra, options)
       javascript_redirect(:action => 'dialog_load')
     end
   end
-
-  def vm_transform
-    dialog = Dialog.find_by(:label => 'Transform VM')
-    if params.key?(:id)
-      vm = Vm.find_by(:id => params[:id].to_i)
-      @right_cell_text = _("Transform VM %{name} to RHV") % {:name => vm.name}
-      dialog_initialize(
-        dialog.resource_actions.first,
-        :header     => @right_cell_text,
-        :target_id  => vm.id,
-        :target_kls => Vm.name
-      )
-    else
-      @right_cell_text = _("Transform VMs to RHV")
-      simple_dialog_initialize(
-        dialog.resource_actions.first,
-        :header => @right_cell_text
-      )
-    end
-  end
 end

spec/controllers/ems_infra_controller_spec.rb

@@ -83,6 +83,13 @@
       post :button, :params => {:pressed => "host_analyze_check_compliance", :id => ems_infra.id, :format => :js}
       expect(controller.send(:flash_errors?)).not_to be_truthy
     end
+
+    it "when vm_transform is pressed" do
+      ems_infra = FactoryGirl.create(:ems_vmware)
+      expect(controller).to receive(:vm_transform)
+      post :button, :params => {:pressed => "vm_transform", :id => ems_infra.id, :format => :js}
+      expect(controller.send(:flash_errors?)).not_to be_truthy
+    end
   end
 
   describe "#create" do