Refactoring code of x_get_tree_custom_kids method #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label refactoring |
mzazrivec
changed the title
hstastna
changed the title
|
@miq-bot add_label wip |
|
Looks good to me. |
hstastna
changed the title
|
@miq-bot remove_label wip |
hstastna
force-pushed
the
x_get_tree_custom_kids_REFACTORING2
branch
from
d662d3c to
48becc6
Compare
depends on ManageIQ#98 Refactoring code of x_get_tree_custom_kids method as the same code needs to be in the method in tree_builder_vms_filter.rb and in tree_builder_storage.rb; moving the code to new methods in miq_search.rb.
hstastna
force-pushed
the
x_get_tree_custom_kids_REFACTORING2
branch
from
48becc6 to
33910f8
Compare
|
Checked commit hstastna@33910f8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring code of x_get_tree_custom_kidsmethod as the
same code needs to be in the method in tree_builder_vms_filter.rb
and in tree_builder_storage.rb;
moving the code to new methods in miq_search.rb.
Depends on
ManageIQ/manageiq#13402 (the second part of this refactoring)