Escape timeline JSON properly #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when used with %script, the resulting json is html-escaped and broken using :javascript now, and moving the logic to a proper function also removed code using empty hash to provide a default value for a json string https://bugzilla.redhat.com/show_bug.cgi?id=1440058
|
@PanSpagetka can you verify this works in all the timelines please? (I don't have much timeline data..) |
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/0db9cb383e660541910edd80a29bc9a789281c71 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@himdel Every timeline i tried works. So i give you this: 🐰 |
simaishi
pushed a commit
that referenced
this pull request
Jun 5, 2017
Escape timeline JSON properly (cherry picked from commit c0c98db) https://bugzilla.redhat.com/show_bug.cgi?id=1458896
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when used with
%script, the resulting json is html-escaped and brokenusing
:javascriptnow, and moving the logic to a proper functionalso removed code using empty hash to provide a default value for a json string.
https://bugzilla.redhat.com/show_bug.cgi?id=1440058