Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flash messages partial view to the edit form of chargeback rates #1076

Conversation

jzigmund
Copy link

The bug was caused by ManageIQ/manageiq#12154, so I've removed the flash message partial from show view and add it to edit view (for new, copy, edit chargeback is used edit view).

https://bugzilla.redhat.com/show_bug.cgi?id=1441152

@miq-bot
Copy link
Member

miq-bot commented Apr 19, 2017

Checked commit jzigmund@143c1c2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@dclarizio dclarizio self-assigned this Apr 24, 2017
@dclarizio dclarizio merged commit 983abc6 into ManageIQ:master Apr 24, 2017
@dclarizio dclarizio added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 24, 2017
simaishi pushed a commit that referenced this pull request Apr 24, 2017
…es_in_chargeback_rates

Add flash messages partial view to the edit form of chargeback rates
(cherry picked from commit 983abc6)

https://bugzilla.redhat.com/show_bug.cgi?id=1445006
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 2c3d8cf1b548ee47ea4c19c86f30e87a423bc8da
Author: Dan Clarizio <[email protected]>
Date:   Mon Apr 24 08:50:16 2017 -0700

    Merge pull request #1076 from jzigmund/bz1441152-missing_flash_messages_in_chargeback_rates
    
    Add flash messages partial view to the edit form of chargeback rates
    (cherry picked from commit 983abc6772d6f65205a4eeeb292ccfaf7be61398)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1445006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants