Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for displaying firmware details #1251

Merged
merged 1 commit into from
May 24, 2017
Merged

Add support for displaying firmware details #1251

merged 1 commit into from
May 24, 2017

Conversation

skovic
Copy link

@skovic skovic commented May 3, 2017 •
edited
Loading

Added support for displaying firmware details on the physical server summary page.

firmware-details

@skovic
Copy link
Author

skovic commented May 3, 2017

@miq-bot add_label wip

@miq-bot miq-bot changed the title Add support for displaying firmware details [WIP] Add support for displaying firmware details May 3, 2017
@miq-bot
Copy link
Member

miq-bot commented May 3, 2017

This pull request is not mergeable. Please rebase and repush.

rodneyhbrown7
rodneyhbrown7 reviewed May 4, 2017
View reviewed changes
app/helpers/physical_server_helper/textual_summary.rb Outdated
def textual_group_compliance
end

def textual_group_firmware_details
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stephen I think how the groups are created has changed now. There are examples in the PR: #274. Can you check to see if you are in sync with those changes?

@skovic skovic closed this May 9, 2017
@skovic skovic reopened this May 9, 2017
@skovic skovic closed this May 9, 2017
@skovic skovic reopened this May 9, 2017
@miq-bot
Copy link
Member

miq-bot commented May 9, 2017

This pull request is not mergeable. Please rebase and repush.

@skovic
Copy link
Author

skovic commented May 10, 2017

@miq-bot remove_label graphics

@miq-bot miq-bot removed the graphics label May 10, 2017
@skovic
Copy link
Author

skovic commented May 10, 2017

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] Add support for displaying firmware details Add support for displaying firmware details May 10, 2017
@miq-bot miq-bot removed the wip label May 10, 2017
@AparnaKarve
Copy link
Contributor

@skovic Please upload a screenshot in your first PR comment that displays the Physical Server Firmware details.

Tested in the UI. LGTM.

@miq-bot
Copy link
Member

miq-bot commented May 10, 2017

This pull request is not mergeable. Please rebase and repush.

@dclarizio dclarizio requested a review from AparnaKarve May 10, 2017 20:58
@dclarizio dclarizio self-assigned this May 10, 2017
AparnaKarve
AparnaKarve approved these changes May 10, 2017
View reviewed changes
Copy link
Contributor

@AparnaKarve AparnaKarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in UI. LGTM.

@miq-bot
Copy link
Member

miq-bot commented May 12, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented May 15, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented May 16, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented May 17, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented May 18, 2017

Checked commit skovic@51f6b07 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@rodneyhbrown7
Copy link

@dclarizio @AparnaKarve Can this PR be merged?

@AparnaKarve
Copy link
Contributor

@rodneyhbrown7 Yes, it can be merged.
@martinpovolny Can you please merge this PR? Thanks.

@martinpovolny martinpovolny merged commit 5bee263 into ManageIQ:master May 24, 2017
@martinpovolny martinpovolny added this to the Sprint 62 Ending Jun 5, 2017 milestone May 24, 2017
@martinpovolny martinpovolny mentioned this pull request Feb 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodneyhbrown7 rodneyhbrown7 rodneyhbrown7 left review comments

@AparnaKarve AparnaKarve AparnaKarve approved these changes

Assignees

@martinpovolny martinpovolny

Labels
compute/physical infrastructure enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skovic @miq-bot @AparnaKarve @rodneyhbrown7 @martinpovolny @dclarizio