Refactor Textual Summary archtecture #1295
Conversation
Refactor physical server textual summary for new archtecture
|
@miq-bot add_labels graphics, textual summaries |
|
Checked commit gabrielsvinha@90e3a5a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot add_label compute/physical infrastructure |
| %i(host) | ||
| TextualGroup.new( | ||
| _("Relationships"), | ||
| %i(host) |
There was a problem hiding this comment.
@gabrielsvinha Can you tell me more about the host relationship?
When I click on host, it takes me to the host/show_list page (with Invalid input flash message) which does not seem right.
There was a problem hiding this comment.
Should it point to a particular host? If so, you need to provide a host id in that link.
I noticed one more thing, the Relationships in the listnav PR
#1195
- looks for
@record.hostfirst before showing that Relationship - shows the Parent Provider (
@record.ext_management_system), which I think is a good idea.
Could you add that relationship here as well?
There was a problem hiding this comment.
You should have a host related to that specific physical server in the show page. It will redirect to this host related.
There was a problem hiding this comment.
The host relationship is expressed in https://github.com/ManageIQ/manageiq/blob/master/app/models/physical_server.rb#L13
There was a problem hiding this comment.
As below, you see the 'mlk' summary with its relationship with 'Imm 0901' host:
After I click in host, it loads this specific host page.
Btw the Physical Infrastructure relationship shown will be added in another Pull Request after #1294 is merged.
This Pull Request makes changes in:
In order to appear Physical Server summary page with the following properties:
Depends on: