Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent button removal text for all discovered / managed items #1669

Merged

Conversation

mzazrivec
Copy link
Contributor

@mzazrivec mzazrivec commented Jul 11, 2017

For removal of all items in our database that we discover and manage in ManageIQ, we're going to
state (in toolbar button texts) that we're deleting the items from inventory (to avoid confusion).

https://www.pivotaltracker.com/story/show/147302217

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1429014

For removal of all items in our database that we discover and manage
in ManageIQ, we're going to state (in toolbar button texts) that we're
deleting the items from inventory (to avoid confusion).
@miq-bot
Copy link
Member

miq-bot commented Jul 11, 2017

Checked commit mzazrivec@57f0417 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
61 files checked, 1 offense detected

app/helpers/application_helper/toolbar/orchestration_template_center.rb

@martinpovolny martinpovolny added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 21, 2017
@martinpovolny martinpovolny merged commit e6f7419 into ManageIQ:master Jul 21, 2017
@mzazrivec mzazrivec deleted the consistent_removal_button_texts branch September 11, 2017 06:33
@Loicavenel
Copy link

@mzazrivec I did check with first 4.6 Downstream and Service has not been updated. We see Remove Service... It should include from Inventory to avoid confusion with Retire Service

@Loicavenel
Copy link

@mzazrivec Did you fix "Remover Service From Inventory"

@mzazrivec
Copy link
Contributor Author

@Loicavenel The task, as it was specified, was to add "Remove ... from Inventory" for all discovered objects / items, not for Services.

If this is to be done for Service as well, then it's a different story.

@mzazrivec
Copy link
Contributor Author

@Loicavenel here you go: #2533

@Loicavenel
Copy link

THANKS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants