Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display checkable folders in the Alert Profile Assignment tree for ems_folder #1747

Merged

Conversation

AparnaKarve
Copy link
Contributor

Fixed the Alert Profiles Assignment tree to display correct nodes when Selected Folders is selected and ensured that the folders are checkable.

Before (Displays wrong nodes + uncheckable nodes)
screen shot 2017-07-24 at 3 43 10 pm

After (Displays correct nodes (folders) that are checkable)
screen shot 2017-07-24 at 6 11 05 pm

https://bugzilla.redhat.com/show_bug.cgi?id=1473321

@AparnaKarve AparnaKarve force-pushed the bz1473321_fix_ems_folder_in_assign_tree branch 4 times, most recently from 08da221 to e9568cb Compare July 25, 2017 17:45
Also other checkbox related properties for Alert Profile
Assignment will be set.
This fixes Alert Profile assignment for ems_folders

https://bugzilla.redhat.com/show_bug.cgi?id=1473321
@AparnaKarve AparnaKarve force-pushed the bz1473321_fix_ems_folder_in_assign_tree branch from e9568cb to d792052 Compare July 27, 2017 16:00
@AparnaKarve AparnaKarve force-pushed the bz1473321_fix_ems_folder_in_assign_tree branch from d792052 to 7911572 Compare July 27, 2017 16:24
@miq-bot
Copy link
Member

miq-bot commented Jul 27, 2017

Checked commits AparnaKarve/manageiq-ui-classic@9ee07bd~...7911572 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@h-kataria
Copy link
Contributor

LGTM, verified fix in UI.

@h-kataria h-kataria added this to the Sprint 66 Ending Aug 7, 2017 milestone Aug 2, 2017
@h-kataria h-kataria merged commit 2e149af into ManageIQ:master Aug 2, 2017
@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

@AparnaKarve app/presenters/tree_builder_belongs_to_hac.rb doesn't exist in Euwe branch and I'm not sure where the change goes. Can you please create a PR for Euwe?

@simaishi
Copy link
Contributor

simaishi commented Aug 9, 2017

@AparnaKarve Backporting to Fine conflicts on both files. Can you please create a Fine PR?

@AparnaKarve
Copy link
Contributor Author

@simaishi
Euwe equivalent is ManageIQ/manageiq#15793, and
Fine equivalent is #1889

Thanks.

@simaishi
Copy link
Contributor

Backported to Fine via #1889

@simaishi simaishi removed the fine/yes label Aug 16, 2017
@simaishi
Copy link
Contributor

Backported to Euwe via ManageIQ/manageiq#15793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants