Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudTenant uses GenericButtonMixin for tagging #1964

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

ZitaNemeckova
Copy link
Contributor

https://bugzilla.redhat.com/show_bug.cgi?id=1383197

Steps to Reproduce:

  1. Navigate to Compute -> Cloud-> Tenants
  2. On tenant summary page click on anything for ex:cloud subnets
  3. Select a one or more in list view and perform actions (delete/Edit tags)

Before: No route matches {:action=>"tag", :controller=>"cloud_volume", :id=>"10000000000004", :miq_grid_checks=>"10r30"} [cloud_tenant/button]
After: It works.

@miq-bot add_label bug, euwe/yes, fine/yes

Call for tagging another object from CloudTenant screen must go via GenericButtonMixin
@miq-bot
Copy link
Member

miq-bot commented Aug 21, 2017

Checked commit ZitaNemeckova@4e2c0c6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec self-assigned this Aug 24, 2017
@mzazrivec mzazrivec added this to the Sprint 68 Ending Sep 4, 2017 milestone Aug 24, 2017
@mzazrivec mzazrivec merged commit 1b4e834 into ManageIQ:master Aug 24, 2017
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit ce96b834fbdf69978d1a764823d9417311ee7637
Author: Milan Zázrivec <[email protected]>
Date:   Thu Aug 24 16:31:08 2017 +0200

    Merge pull request #1964 from ZitaNemeckova/tag_from_tenant
    
    CloudTenant uses GenericButtonMixin for tagging
    (cherry picked from commit 1b4e834fa451da132f53c3c9e8b3c0f294a6764e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1487307

@ZitaNemeckova ZitaNemeckova deleted the tag_from_tenant branch September 12, 2017 14:11
simaishi pushed a commit that referenced this pull request Nov 13, 2017
CloudTenant uses GenericButtonMixin for tagging
(cherry picked from commit 1b4e834)

https://bugzilla.redhat.com/show_bug.cgi?id=1487306
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 6675fff356eefd6cf5026868db730fa4dade5581
Author: Milan Zázrivec <[email protected]>
Date:   Thu Aug 24 16:31:08 2017 +0200

    Merge pull request #1964 from ZitaNemeckova/tag_from_tenant
    
    CloudTenant uses GenericButtonMixin for tagging
    (cherry picked from commit 1b4e834fa451da132f53c3c9e8b3c0f294a6764e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1487306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants