Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated style for Dialog Editor #2116

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

romanblanco
Copy link
Member

@miq-bot
Copy link
Member

miq-bot commented Sep 6, 2017

Checked commit romanblanco@ac550a1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romanblanco, LGTM

@romanblanco
Copy link
Member Author

romanblanco commented Sep 7, 2017

ping @martinpovolny
can you merge this one together with ManageIQ/ui-components#139?

@martinpovolny martinpovolny self-assigned this Sep 7, 2017
@martinpovolny martinpovolny merged commit 6e8bc77 into ManageIQ:master Sep 7, 2017
@martinpovolny martinpovolny added this to the Sprint 69 Ending Sep 18, 2017 milestone Sep 7, 2017
@romanblanco romanblanco deleted the update_dialog_editor branch September 7, 2017 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants